[Mesa-dev] [PATCH 2/5] st/mesa: don't check for ARB_draw_buffers_blend in update_blend

Marek Olšák maraeo at gmail.com
Wed Feb 7 23:55:51 UTC 2018


On Wed, Feb 7, 2018 at 11:56 PM, Timothy Arceri <tarceri at itsqueeze.com> wrote:
>
> On 01/02/18 06:55, Marek Olšák wrote> From: Marek Olšák
> <marek.olsak at amd.com>
>>
>>
>> If the GL API is missing, different blend functions can't be set
>> through GL.
>
>
> Looking at the commit that added this a476ca1fd1b4e7 the commit message is:
>
> "st/mesa: Use blend equation and function of first render target for all
> render targets if ARB_draw_buffers_blend is not supported
>
>     If EXT_draw_buffers2 is supported but ARB_draw_buffers_blend isn't
>     _mesa_BlendFuncSeparateEXT only sets up the blend equation and function
> for the
>     first render target. This patch makes sure that update_blend doesn't try
> to use
>     the data from other rendertargets in such cases"
>
> So it seems to me that before this patch we should probably have a patch the
> commbines the two caps PIPE_CAP_INDEP_BLEND_ENABLE and
> PIPE_CAP_INDEP_BLEND_FUNC.

No, I'll just ditch this patch.

Marek


More information about the mesa-dev mailing list