[Mesa-dev] [PATCH 02/29] i965/surface_state: Use an identity swizzle pre-Haswell

[Kenneth Graunke]

On Friday, January 26, 2018 5:59:31 PM PST Jason Ekstrand wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> index 611e850..39985f0 100644
> --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> @@ -559,6 +559,12 @@ static void brw_update_texture_surface(struct gl_context *ctx,
>           .usage = ISL_SURF_USAGE_TEXTURE_BIT,
>        };
>  
> +      /* On Ivy Bridge and earlier, we handle texture swizzle with shader
> +       * code.  The actual surface swizzle should be identity.
> +       */
> +      if (brw->gen <= 7 && !brw->is_haswell)

Needs to be devinfo, not brw.  You fixed this but accidentally squashed
it into the next patch instead of this one.

> +         view.swizzle = ISL_SWIZZLE_IDENTITY;
> +
>        if (obj->Target == GL_TEXTURE_CUBE_MAP ||
>            obj->Target == GL_TEXTURE_CUBE_MAP_ARRAY)
>           view.usage |= ISL_SURF_USAGE_CUBE_BIT;
> 

Patches 2-4 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180207/1e9d8aeb/attachment.sig>