[Mesa-dev] [PATCH] meson: Add build option for tools

[Eric Engestrom]

On Thursday, 2018-02-08 01:30:04 -0800, Jordan Justen wrote:
> On 2018-02-07 16:55:24, Scott D Phillips wrote:
> > diff --git a/src/compiler/glsl/meson.build b/src/compiler/glsl/meson.build
> > index b0c0de810a6..6c46e466c96 100644
> > --- a/src/compiler/glsl/meson.build
> > +++ b/src/compiler/glsl/meson.build
> > @@ -230,7 +230,8 @@ glsl_compiler = executable(
> >    dependencies : [dep_clock, dep_thread],
> >    include_directories : [inc_common],
> >    link_with : [libglsl_standalone],
> > -  build_by_default : false,
> > +  build_by_default : with_tools.contains('glsl'),
> > +  install : true,
> 
> Thanks for looking at this!
> 
> I found that the install will still be attempted even if it isn't
> built, so you should add with_tools.contains('foo') to the install
> lines as well.

I was about to say that, good thing I read the replies first :)

> With that:
> 
> Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>