[Mesa-dev] [PATCH 10.5/24] st/mesa: don't set sampler states for TBOs

[Eric Anholt]

Marek Olšák <maraeo at gmail.com> writes:

> On Wed, Feb 7, 2018 at 1:33 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> This breaks nouveau (at least on nv50). Same deal as in commit
>> 2b938a390c15a06be8cf706083890c822979508f which fixed a similar issue
>> where this assumption that buffer doesn't need sampler was also
>> temporarily introduced.
>>
>> Do I need to go change a ton of stuff in nouveau, or can we stick with
>> the original rule where there's a always a sampler associated with a
>> view?
>
> Updating sampler states here would add overhead to all drivers, so
> let's consider it an nvidia hardware issue needing a workaround in
> nouveau.

VC5 also uses the sampler along with the view for all its sampler
uniforms, so I guess I'll need to flag non-sampler-using sampler uniform
references.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180208/d33b6115/attachment.sig>