[Mesa-dev] [PATCH v3 5/9] meson: fix vdpau target linkage

Emil Velikov emil.l.velikov at gmail.com
Thu Feb 8 23:17:16 UTC 2018


On 8 February 2018 at 23:11, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 2 February 2018 at 19:30, Dylan Baker <dylan at pnwbakers.com> wrote:
>> The VDPAU state tracker needs to be linked with whole-archive (autotools
>> does this). Because we are linking the whole archive we alos need to
>> link with libswdri and libswkmsdri if those have been enabled.
>>
>> Fixes: 68076b87474e7959 ("meson: build gallium vdpau state tracker")
>> Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
>> ---
>
>> +if with_dri
>> +  vdpau_link_with += libswdri
>> +endif
>> +if with_gallium_drisw_kms
>> +  vdpau_link_with += libswkmsdri
>> +endif
>> +
> This is not specific for vdpau - va/omx/etc also need it.
> Instead of duplicating the code - one could fold that once into
> another meson.build file.
>
As an example - the rest of the series does copy the exact same hunk
across the remainder.
When we already have it in nine and dri targets :-\

Thanks
Emil


More information about the mesa-dev mailing list