[Mesa-dev] [PATCH v3 4/9] meson: Actually link xvmc target with libxvmc

[Emil Velikov]

On 8 February 2018 at 23:33, Dylan Baker <dylan at pnwbakers.com> wrote:
> Quoting Emil Velikov (2018-02-08 15:09:13)
>> On 2 February 2018 at 19:30, Dylan Baker <dylan at pnwbakers.com> wrote:
>> > Unlike vdpau this is required.
>> >
>> > Fixes: 22a817af8a89eb3c7 ("meson: build gallium xvmc state tracker")
>> > Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
>> > ---
>> >  meson.build | 3 ---
>> >  1 file changed, 3 deletions(-)
>> >
>> > diff --git a/meson.build b/meson.build
>> > index 2df2497..4f280d9 100644
>> > --- a/meson.build
>> > +++ b/meson.build
>> > @@ -439,9 +439,6 @@ with_gallium_xvmc = _xvmc == 'true'
>> >  dep_xvmc = []
>> >  if with_gallium_xvmc
>> >    dep_xvmc = dependency('xvmc', version : '>= 1.0.6')
>> > -  dep_xvmc = declare_dependency(
>> > -    compile_args : run_command(prog_pkgconfig, ['xvmc', '--cflags']).stdout().split()
>> > -  )
>> Out of curiosity: does meson warn when you override a dependency like above?
>> Even if the old information isn't used to derive the new one.
>>
>> If not it might be worth throwing a warning.
>> Emil
>
> It doesn't. We could certainly look into that. Meson is trying to decide how
> strongly typed it's going to be right now, so we'll have to talk about it with
> upstream.
>
Right. Even if it ends up being weak typed, having the warning hidden
behind a toggle would be a wise move. Even if it is
"enable-stupid-shadowing-warnings" ;-)
Chasing bugs caused due to shadowing can be quite frustrating.

-Emil