[Mesa-dev] [PATCH] st/mesa: update the blend before a full color clear

[Marek Olšák]

On Fri, Feb 9, 2018 at 2:12 AM, Gurchetan Singh
<gurchetansingh at chromium.org> wrote:
> On Thu, Feb 8, 2018 at 4:46 PM, Marek Olšák <maraeo at gmail.com> wrote:
>>
>> This is not the correct fix.
>>
>> clear_with_quad calls cso_set_blend. pipe->clear ignores (and should
>> ignore) the blend state. There is no scenario where you would have to
>> call st_update_blend for pipe->clear. I think this is a virgl bug in
>> pipe->clear.
>
>
> clear_with_quad is only called if a color mask exists (see is_color_masked).
> When the state transitions from color-mask exists --> completely unmasked
> (the clear_buffers case), how is the driver supposed to be notified?

The driver isn't notified. It should ignore the blend state entirely
and always use the full mask for full clears.

Marek