[Mesa-dev] [PATCH 01/18] egl/wayland: Fix ARGB/XRGB transposition in config map

[Daniel Stone]

Hi Eric,

On 8 February 2018 at 18:40, Eric Engestrom <eric at engestrom.ch> wrote:
> On February 8, 2018 2:06:23 PM UTC, Daniel Stone <daniels at collabora.com> wrote:
>> When 0b2b7191214eb moved from an if tree to a struct to map between
>> wl_drm formats and EGLConfigs, it transposed the mapping between XRGB
>> and ARGB. Luckily, everyone exposes both formats, so this is harmless.
>
> Reviewed-by: Eric Engestrom <eric at engestrom.ch>
>
> (On my phone and you cc'ed me, but I'll also review the rest of the series tomorrow)

Thanks!

>> -      { "ARGB8888", HAS_ARGB8888, { 0xff0000, 0xff00, 0x00ff, 0 } },
>> +      { "XRGB8888", HAS_XRGB8888, { 0xff0000, 0xff00, 0x00ff, 0 } },
>> +      { "ARGB8888", HAS_ARGB8888, { 0xff0000, 0xff00, 0x00ff,
>> 0xff000000 } },
>>        { "RGB565",   HAS_RGB565,   { 0x00f800, 0x07e0, 0x001f, 0 } },
>
> One note though, the prefixing 0s are very inconsistent in this table, might be worth cleaning that up too?

Oh, you're going to love patch 3.

Cheers,
Daniel