[Mesa-dev] [PATCH] anv: Drop I915_EXEC_CONSTANTS_REL_GENERAL from execbuf.

[Jason Ekstrand]

Rb


On February 11, 2018 17:50:16 Kenneth Graunke <kenneth at whitecape.org> wrote:

> The kernel used to have execbuf parameters to program the INSTPM bit
> for whether 3DSTATE_CONSTANT_* should be relative to dynamic state
> base address or an absolute address.  However, they never worked in
> the presence of hardware contexts, so I deleted them a while back.
>
> It doesn't make sense to set this flag, as it doesn't exist anymore.
> It also never did anything anyway - the flag is zero, so |'ing it in
> did nothing.  The default is relative anyway.
> ---
>  src/intel/vulkan/anv_batch_chain.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_batch_chain.c 
> b/src/intel/vulkan/anv_batch_chain.c
> index 85444e64cec..13d55e0efe1 100644
> --- a/src/intel/vulkan/anv_batch_chain.c
> +++ b/src/intel/vulkan/anv_batch_chain.c
> @@ -1375,8 +1375,7 @@ setup_execbuf_for_cmd_buffer(struct anv_execbuf *execbuf,
>        .num_cliprects = 0,
>        .DR1 = 0,
>        .DR4 = 0,
> -      .flags = I915_EXEC_HANDLE_LUT | I915_EXEC_RENDER |
> -               I915_EXEC_CONSTANTS_REL_GENERAL,
> +      .flags = I915_EXEC_HANDLE_LUT | I915_EXEC_RENDER,
>        .rsvd1 = cmd_buffer->device->context_id,
>        .rsvd2 = 0,
>     };
> --
> 2.16.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev