[Mesa-dev] [PATCH] nvc0: disable MS Images for sample_count == 1 on Maxwell

[Ilia Mirkin]

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

I think things brings up the MSAAx1 question again. Apparently you're
allowed to use a MSAAx1 image with image2DMS? Anyways, we can just
avoid it all for now by not supporting it.

On Mon, Feb 12, 2018 at 8:46 AM, Karol Herbst <kherbst at redhat.com> wrote:
> fixes KHR-GL45.multi_bind.dispatch_bind_textures on Maxwell
>
> Suggested-by: Ilia Mirkin <imirkin at alum.mit.edu>
> Signed-off-by: Karol Herbst <kherbst at redhat.com>
> ---
>  src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> index 7ba8086a533..67cd6f44ca7 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> @@ -88,7 +88,7 @@ nvc0_screen_is_format_supported(struct pipe_screen *pscreen,
>                   PIPE_BIND_SHARED);
>
>     if (bindings & PIPE_BIND_SHADER_IMAGE) {
> -      if (sample_count > 1 &&
> +      if (sample_count > 0 &&
>            nouveau_screen(pscreen)->class_3d >= GM107_3D_CLASS) {
>           /* MS images are currently unsupported on Maxwell because they have to
>            * be handled explicitly. */
> --
> 2.14.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev