[Mesa-dev] [PATCH] i965: Fix bugs in intel_from_planar

Jason Ekstrand jason at jlekstrand.net
Mon Feb 12 17:50:01 UTC 2018


On Mon, Feb 12, 2018 at 9:45 AM, Daniel Stone <daniel at fooishbar.org> wrote:

> Hi,
>
> On 12 February 2018 at 17:16, Jason Ekstrand <jason at jlekstrand.net> wrote:
> > On Mon, Feb 12, 2018 at 6:36 AM, Daniel Stone <daniel at fooishbar.org>
> wrote:
> >> On further thought, I don't see how this could work at all. If we call
> >> fromPlanar on plane 0 of a non-planar image with an aux plane, we need
> >> to land in the first branch (due to the assert). But since plane 0 is
> >> strictly less than the number of planes 1, we don't.
> >>
> >> I think something like this: https://hastebin.com/axuqorenax
> >
> > I like that.  Mind making a proper patch out of it (not based on this
> one)
> > and sending to the list?  Between the four of us, maybe we can write this
> > correctly. :-)
>
> Oh yeah. I'm just waiting for my repo to get reactivated for CI
> runners, so I can find out what I broke with that strawman. :)
>

Eh.  Just send it to the list.  I can run it through CI.

--Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180212/228d3651/attachment.html>


More information about the mesa-dev mailing list