[Mesa-dev] [PATCH 07/17] glsl: Silence warnings in the uniform initializer test about 16-bit types

Ian Romanick idr at freedesktop.org
Mon Feb 12 20:00:44 UTC 2018


Shutting up this warning has been (fairly low) on my to-do list for some
time now... thanks for beating me to it. :)

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 02/10/2018 08:33 AM, Eric Anholt wrote:
> They should probably get unit tests implemented, but this cleans up a
> bunch of warnings in my build for now.
> 
> Fixes: 59f458cd8703 ("glsl: Add 16-bit types")
> Cc: Eduardo Lima Mitev <elima at igalia.com>
> ---
>  src/compiler/glsl/tests/uniform_initializer_utils.cpp | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/src/compiler/glsl/tests/uniform_initializer_utils.cpp b/src/compiler/glsl/tests/uniform_initializer_utils.cpp
> index c5502b632697..701c8ef4d091 100644
> --- a/src/compiler/glsl/tests/uniform_initializer_utils.cpp
> +++ b/src/compiler/glsl/tests/uniform_initializer_utils.cpp
> @@ -110,6 +110,9 @@ generate_data_element(void *mem_ctx, const glsl_type *type,
>        case GLSL_TYPE_INTERFACE:
>        case GLSL_TYPE_SUBROUTINE:
>        case GLSL_TYPE_FUNCTION:
> +      case GLSL_TYPE_FLOAT16:
> +      case GLSL_TYPE_UINT16:
> +      case GLSL_TYPE_INT16:
>  	 ASSERT_TRUE(false);
>  	 break;
>        }
> @@ -150,6 +153,9 @@ generate_data_element(void *mem_ctx, const glsl_type *type,
>        case GLSL_TYPE_INTERFACE:
>        case GLSL_TYPE_SUBROUTINE:
>        case GLSL_TYPE_FUNCTION:
> +      case GLSL_TYPE_FLOAT16:
> +      case GLSL_TYPE_UINT16:
> +      case GLSL_TYPE_INT16:
>  	 ASSERT_TRUE(false);
>  	 break;
>        }
> @@ -262,6 +268,9 @@ verify_data(gl_constant_value *storage, unsigned storage_array_size,
>  	 case GLSL_TYPE_INTERFACE:
>  	 case GLSL_TYPE_SUBROUTINE:
>           case GLSL_TYPE_FUNCTION:
> +         case GLSL_TYPE_FLOAT16:
> +         case GLSL_TYPE_UINT16:
> +         case GLSL_TYPE_INT16:
>  	    ASSERT_TRUE(false);
>  	    break;
>  	 }
> 



More information about the mesa-dev mailing list