[Mesa-dev] [PATCH 1/3] etnaviv: add debug switch to disable single buffer feature

[Christian Gmeiner]

2018-02-06 10:36 GMT+01:00 Lucas Stach <l.stach at pengutronix.de>:
> This feature has caused some trouble already. Add a debug switch to
> allow users to quickly check if a specific issue is caused by this
> feature.
>
> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>

Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>

> ---
>  src/gallium/drivers/etnaviv/etnaviv_debug.h  | 1 +
>  src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 +++
>  2 files changed, 4 insertions(+)
>
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_debug.h b/src/gallium/drivers/etnaviv/etnaviv_debug.h
> index f47dffe59008..4051e95dd5fb 100644
> --- a/src/gallium/drivers/etnaviv/etnaviv_debug.h
> +++ b/src/gallium/drivers/etnaviv/etnaviv_debug.h
> @@ -52,6 +52,7 @@
>  #define ETNA_DBG_ZERO            0x200000 /* Zero all resources after allocation */
>  #define ETNA_DBG_DRAW_STALL      0x400000 /* Stall FE/PE after every draw op */
>  #define ETNA_DBG_SHADERDB        0x800000 /* dump program compile information */
> +#define ETNA_DBG_NO_SINGLEBUF    0x1000000 /* disable single buffer feature */
>
>  extern int etna_mesa_debug; /* set in etna_screen.c from ETNA_DEBUG */
>
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c
> index d5d1f4fdad2c..7b4034641d18 100644
> --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c
> +++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c
> @@ -68,6 +68,7 @@ static const struct debug_named_value debug_options[] = {
>     {"zero",           ETNA_DBG_ZERO, "Zero all resources after allocation"},
>     {"draw_stall",     ETNA_DBG_DRAW_STALL, "Stall FE/PE after each rendered primitive"},
>     {"shaderdb",       ETNA_DBG_SHADERDB, "Enable shaderdb output"},
> +   {"no_singlebuffer",ETNA_DBG_NO_SINGLEBUF, "Disable single buffer feature"},
>     DEBUG_NAMED_VALUE_END
>  };
>
> @@ -967,6 +968,8 @@ etna_screen_create(struct etna_device *dev, struct etna_gpu *gpu,
>        screen->features[viv_chipMinorFeatures1] &= ~chipMinorFeatures1_AUTO_DISABLE;
>     if (DBG_ENABLED(ETNA_DBG_NO_SUPERTILE))
>        screen->specs.can_supertile = 0;
> +   if (DBG_ENABLED(ETNA_DBG_NO_SINGLEBUF))
> +      screen->specs.single_buffer = 0;
>
>     pscreen->destroy = etna_screen_destroy;
>     pscreen->get_param = etna_screen_get_param;
> --
> 2.15.1
>
> _______________________________________________
> etnaviv mailing list
> etnaviv at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/etnaviv



-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info