[Mesa-dev] [PATCH 2/3] anv/gen10: Remove warning message.

Kenneth Graunke kenneth at whitecape.org
Tue Feb 13 23:05:31 UTC 2018


On Tuesday, February 13, 2018 1:51:54 PM PST Rafael Antognolli wrote:
> Gen10 seems pretty stable so far, remove "alpha support" message.
> 
> Signed-off-by: Rafael Antognolli <rafael.antognolli at intel.com>
> Cc: Jason Ekstrand <jason at jlekstrand.net>
> Cc: "18.0" mesa-stable at lists.freedesktop.org
> ---
>  src/intel/vulkan/anv_device.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 86c1bdc1d51..7390fc3600b 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -312,11 +312,9 @@ anv_physical_device_init(struct anv_physical_device *device,
>        intel_logw("Ivy Bridge Vulkan support is incomplete");
>     } else if (device->info.gen == 7 && device->info.is_baytrail) {
>        intel_logw("Bay Trail Vulkan support is incomplete");
> -   } else if (device->info.gen >= 8 && device->info.gen <= 9) {
> -      /* Broadwell, Cherryview, Skylake, Broxton, Kabylake, Coffelake is as
> -       * fully supported as anything */
> -   } else if (device->info.gen == 10) {
> -      intel_logw("Cannonlake Vulkan support is alpha");
> +   } else if (device->info.gen >= 8 && device->info.gen <= 10) {
> +      /* Broadwell, Cherryview, Skylake, Broxton, Kabylake, Coffelake,
> +       * Cannonlake is as fully supported as anything */

Getting a pretty huge list of codenames here, and Coffee was misspelled.
I'd just change it to /* Gen8-10 fully supported */ or some such.

Series is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

>     } else {
>        result = vk_errorf(device->instance, device,
>                           VK_ERROR_INCOMPATIBLE_DRIVER,
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180213/7c2d1ba9/attachment.sig>


More information about the mesa-dev mailing list