[Mesa-dev] [PATCH 10/16] i965/icl: Define and use icl mocs settings

Kenneth Graunke kenneth at whitecape.org
Wed Feb 14 02:19:21 UTC 2018


On Tuesday, February 13, 2018 11:15:10 AM PST Anuj Phogat wrote:
> Gen11 MOCS settings are duplicate of Gen10 MOCS settings.
> 
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
>  src/mesa/drivers/dri/i965/brw_state.h            | 6 ++++++
>  src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 ++
>  src/mesa/drivers/dri/i965/genX_state_upload.c    | 4 +++-
>  3 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_state.h b/src/mesa/drivers/dri/i965/brw_state.h
> index 709896be3e..3602e3dd6e 100644
> --- a/src/mesa/drivers/dri/i965/brw_state.h
> +++ b/src/mesa/drivers/dri/i965/brw_state.h
> @@ -386,6 +386,12 @@ void gen11_init_atoms(struct brw_context *brw);
>  /* TC=LLC/eLLC, LeCC=PTE, LRUM=3, L3CC=WB */
>  #define CNL_MOCS_PTE (1 << 1)
>  
> +/* Ice Lake uses same MOCS settings as Cannonlake */
> +/* TC=LLC/eLLC, LeCC=WB, LRUM=3, L3CC=WB */
> +#define ICL_MOCS_WB  (2 << 1)
> +/* TC=LLC/eLLC, LeCC=PTE, LRUM=3, L3CC=WB */
> +#define ICL_MOCS_PTE (1 << 1)
> +

This is all a bit silly now that MOCS is just an index into a table
set by the kernel...we were already relying on the fact that SKL_MOCS_*
== CNL_MOCS_* in some places...

But, we can clean it up later...so...

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180213/21bc600a/attachment.sig>


More information about the mesa-dev mailing list