[Mesa-dev] [PATCH 07/16] i965/icl: Don't set ResetGatewayTimer

[Kenneth Graunke]

On Tuesday, February 13, 2018 11:15:07 AM PST Anuj Phogat wrote:
> This field is removed in gen11+
> 
> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> ---
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c
> index 67fb328dbc..29739ba051 100644
> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -4215,8 +4215,10 @@ genX(upload_cs_state)(struct brw_context *brw)
>        const uint32_t subslices = MAX2(brw->screen->subslice_total, 1);
>        vfe.MaximumNumberofThreads = devinfo->max_cs_threads * subslices - 1;
>        vfe.NumberofURBEntries = GEN_GEN >= 8 ? 2 : 0;
> +#if GEN_GEN < 11
>        vfe.ResetGatewayTimer =
>           Resettingrelativetimerandlatchingtheglobaltimestamp;
> +#endif
>  #if GEN_GEN < 9
>        vfe.BypassGatewayControl = BypassingOpenGatewayCloseGatewayprotocol;
>  #endif
> 

So it is.  I wonder why we set this on older platforms.  I'm guessing
we don't need to, and could have just used the "keep the timestamp"
value...deleting this code entirely.  But, I'm not sure either.

For now, this seems like a good plan.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180213/4341f609/attachment.sig>