[Mesa-dev] [PATCH 0/6] OpenGL 3.1 + ARB_compatibility and related stuff (v2)

[Mike Lothian]

On 15 February 2018 at 00:11, Marek Olšák <maraeo at gmail.com> wrote:
> Hi,
>
> This is the second version of GL 3.1 compatibility support patches.
> There is also ARB_enhanced_layouts for the compatibility context and
> other related changes.
>
> Please review.
>
> Thanks,
> Marek
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

So I've done my best to test this. These are the diffs between the
glxinfo reports before and after on radeonsi and i965


fireburn at axion ~ $ diff -u glxinfo.amdgpu.core glxinfo.amdgpu.compat
--- glxinfo.amdgpu.core 2018-02-15 01:05:48.081778762 +0000
+++ glxinfo.amdgpu.compat       2018-02-15 01:39:04.727660602 +0000
@@ -105,7 +105,7 @@
    Unified memory: no
    Preferred profile: core (0x1)
    Max core profile version: 4.5
-    Max compat profile version: 3.0
+    Max compat profile version: 3.1
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.1
Memory info (GL_ATI_meminfo):
@@ -121,7 +121,7 @@
    Currently available dedicated video memory: 4089 MB
OpenGL vendor string: X.Org
OpenGL renderer string: AMD Radeon R9 M295X (TONGA / DRM 3.25.0 /
4.15.0-rc8-agd5f+, LLVM 7.0.0)
-OpenGL core profile version string: 4.5 (Core Profile) Mesa
18.1.0-devel (git-0cd37f9178)
+OpenGL core profile version string: 4.5 (Core Profile) Mesa
18.1.0-devel (git-c6694793e1)
OpenGL core profile shading language version string: 4.50
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile
@@ -325,8 +325,8 @@
    GL_S3_s3tc


-OpenGL version string: 3.0 Mesa 18.1.0-devel (git-0cd37f9178)
-OpenGL shading language version string: 1.30
+OpenGL version string: 3.1 Mesa 18.1.0-devel (git-c6694793e1)
+OpenGL shading language version string: 1.40
OpenGL context flags: (none)
OpenGL extensions:
    GL_AMD_conservative_depth
@@ -350,6 +350,7 @@
    GL_ARB_clear_texture
    GL_ARB_clip_control
    GL_ARB_color_buffer_float
+    GL_ARB_compatibility
    GL_ARB_compressed_texture_pixel_storage
    GL_ARB_compute_shader
    GL_ARB_compute_variable_group_size
@@ -367,6 +368,7 @@
    GL_ARB_draw_buffers_blend
    GL_ARB_draw_elements_base_vertex
    GL_ARB_draw_instanced
+    GL_ARB_enhanced_layouts
    GL_ARB_explicit_attrib_location
    GL_ARB_explicit_uniform_location
    GL_ARB_fragment_coord_conventions
@@ -588,7 +590,7 @@
    GL_SUN_multi_draw_arrays


-OpenGL ES profile version string: OpenGL ES 3.1 Mesa 18.1.0-devel
(git-0cd37f9178)
+OpenGL ES profile version string: OpenGL ES 3.1 Mesa 18.1.0-devel
(git-c6694793e1)
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.10
OpenGL ES profile extensions:
    GL_ANGLE_texture_compression_dxt3
fireburn at axion ~ $ diff -u glxinfo.intel.core glxinfo.intel.compat
--- glxinfo.intel.core  2018-02-15 01:05:53.581770479 +0000
+++ glxinfo.intel.compat        2018-02-15 01:38:54.077684665 +0000
@@ -111,7 +111,7 @@
    Max GLES[23] profile version: 3.2
OpenGL vendor string: Intel Open Source Technology Center
OpenGL renderer string: Mesa DRI Intel(R) HD Graphics 530 (Skylake GT2)
-OpenGL core profile version string: 4.5 (Core Profile) Mesa
18.1.0-devel (git-0cd37f9178)
+OpenGL core profile version string: 4.5 (Core Profile) Mesa
18.1.0-devel (git-c6694793e1)
OpenGL core profile shading language version string: 4.50
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile
@@ -309,8 +309,8 @@
    GL_S3_s3tc


-OpenGL version string: 3.0 Mesa 18.1.0-devel (git-0cd37f9178)
-OpenGL shading language version string: 1.30
+OpenGL version string: 3.0 Mesa 18.1.0-devel (git-c6694793e1)
+OpenGL shading language version string: 1.40
OpenGL context flags: (none)
OpenGL extensions:
    GL_3DFX_texture_compression_FXT1
@@ -557,7 +557,7 @@
    GL_SUN_multi_draw_arrays


-OpenGL ES profile version string: OpenGL ES 3.2 Mesa 18.1.0-devel
(git-0cd37f9178)
+OpenGL ES profile version string: OpenGL ES 3.2 Mesa 18.1.0-devel
(git-c6694793e1)
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20
OpenGL ES profile extensions:
    GL_ANDROID_extension_pack_es31a

I'm not aware of anything that uses OpenGL 3.1 Compat or the
ARB_compatability extension, but if you know of anything I'll test it
directly

Should i965 show the extra extensions or a higher compat version as
well as the bump to the GLSL version?

My games continue to work after this change is applied

Tested-by: Mike Lothian <mike at fireburn.co.uk>