[Mesa-dev] [PATCH mesa] glsl: fix sizeof(pointer) bug

Brian Paul brianp at vmware.com
Thu Feb 15 15:02:26 UTC 2018


On 02/15/2018 04:01 AM, Eric Engestrom wrote:
> Doesn't really change anything to the test though ¯\_(ツ)_/¯
> 
> CID: 1429511
> Fixes: e8495646afb06a9dd7786 "glsl/tests: changes to test_disk_cache_create test"
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> ---
>   src/compiler/glsl/tests/cache_test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compiler/glsl/tests/cache_test.c b/src/compiler/glsl/tests/cache_test.c
> index 3edd88b06a158d8c4b46..9d7bde2834c827a10757 100644
> --- a/src/compiler/glsl/tests/cache_test.c
> +++ b/src/compiler/glsl/tests/cache_test.c
> @@ -186,7 +186,7 @@ static void *
>   cache_exists(struct disk_cache *cache)
>   {
>      uint8_t dummy_key[20];
> -   char *data = "some test data";
> +   char data[] = "some test data";
>   
>      if (!cache)
>         return NULL;
> 

Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the mesa-dev mailing list