[Mesa-dev] [PATCH v3 00/18] Rework subpass clears and transitions

Iago Toral itoral at igalia.com
Fri Feb 16 12:26:53 UTC 2018


Hi Jason, I have just noticed that this series also conflicts with the
new version of the multiview clearing series I have just sent, I guess
we should wait until this lands first?

Iago

On Wed, 2018-02-14 at 12:16 -0800, Jason Ekstrand wrote:
> This is another version of my patch series to rework subpass clears
> and
> transitions.  It's fairly similar to the other one I sent out except
> that
> it's been rebased on top of the resolve reworks and has some fixes
> from
> Nanley.  There are also two patches on the front side to remove some
> potential non-determanism in the Vulkan driver.
> 
> Jason Ekstrand (18):
>   intel/isl: Add an isl_color_value_is_zero helper
>   anv: Be more careful about fast-clear colors
>   intel/blorp: Use the hardware op for CCS ambiguate on gen10+
>   anv: Use framebuffer layers for implicit subpass transitions
>   anv/cmd_buffer: Apply subpass flushes before set_subpass
>   anv/cmd_buffer: Add begin/end_subpass helpers
>   anv/cmd_buffer: Pass a subpass id into begin_subpass
>   anv/cmd_buffer: Move the color portion of clear_subpass into
>     begin_subpass
>   intel/blorp: Add a blorp_hiz_clear_depth_stencil helper
>   anv/cmd_buffer: Move the rest of clear_subpass into begin_subpass
>   anv/cmd_buffer: Decide whether or not to HiZ clear up-front
>   anv/cmd_buffer: Iterate all subpass attachments when clearing
>   anv/cmd_buffer: Add a concept of pending load aspects
>   anv/pass: Store usage in each subpass attachment
>   anv/cmd_buffer: Sync clear values in begin_subpass
>   anv/cmd_buffer: Mark depth/stencil surfaces written in
> begin_subpass
>   anv/cmd_buffer: Do subpass image transitions in begin/end_subpass
>   anv/cmd_buffer: Avoid unnecessary transitions before fast clears
> 
>  src/intel/blorp/blorp.h            |  11 +
>  src/intel/blorp/blorp_clear.c      |  65 +++-
>  src/intel/blorp/blorp_genX_exec.h  |   6 +
>  src/intel/isl/isl.c                |  20 ++
>  src/intel/isl/isl.h                |   3 +
>  src/intel/vulkan/anv_blorp.c       | 366 ++++++++-------------
>  src/intel/vulkan/anv_pass.c        |  35 +-
>  src/intel/vulkan/anv_private.h     |  42 ++-
>  src/intel/vulkan/genX_cmd_buffer.c | 644 +++++++++++++++++++++----
> ------------
>  9 files changed, 663 insertions(+), 529 deletions(-)
> 


More information about the mesa-dev mailing list