[Mesa-dev] [PATCH] anv/entrypoints: make vkGetDeviceProcAddr return NULL for instance commands

Jason Ekstrand jason at jlekstrand.net
Mon Feb 19 17:52:42 UTC 2018


On Mon, Feb 19, 2018 at 8:35 AM, Emil Velikov <emil.l.velikov at gmail.com>
wrote:

> On 19 February 2018 at 10:54, Iago Toral Quiroga <itoral at igalia.com>
> wrote:
> > The Vulkan working group has recently clarified that this is the intended
> > behavior and accepted spec language changes to make this clear.
> > ---
> >  src/intel/vulkan/anv_entrypoints_gen.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/intel/vulkan/anv_entrypoints_gen.py
> b/src/intel/vulkan/anv_entrypoints_gen.py
> > index c5a654f19b2..34ffedb1165 100644
> > --- a/src/intel/vulkan/anv_entrypoints_gen.py
> > +++ b/src/intel/vulkan/anv_entrypoints_gen.py
> > @@ -225,7 +225,7 @@ anv_entrypoint_is_enabled(int index, uint32_t
> core_version,
> >        return ${e.core_version.c_vk_version()} <= core_version;
> >     % elif e.extension:
> >        % if e.extension.type == 'instance':
> > -      return instance->${e.extension.name[3:]};
> > +      return !device && instance->${e.extension.name[3:]};
>
>
> Out of curiosity - is this documented in the loader <> ICD interface spec?
> Haven't looked recently: perhaps we should bump the version advertised?
>
> Might also be applicable for the (return NULL) fixes from Jason.
>

No, it's documented in the Vulkan spec itself.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180219/b0cd85ce/attachment-0001.html>


More information about the mesa-dev mailing list