[Mesa-dev] [PATCH 1/2] ac/nir: set the DA field when performing atomics on 3D images

Samuel Pitoiset samuel.pitoiset at gmail.com
Tue Feb 20 10:11:42 UTC 2018


This doesn't fix anything known but it should definitely be set.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/common/ac_nir_to_llvm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index dc471de977..9244f8bc7b 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@ -3764,7 +3764,8 @@ static LLVMValueRef visit_image_atomic(struct ac_nir_context *ctx,
 		char coords_type[8];
 
 		bool da = glsl_sampler_type_is_array(type) ||
-		          glsl_get_sampler_dim(type) == GLSL_SAMPLER_DIM_CUBE;
+		          glsl_get_sampler_dim(type) == GLSL_SAMPLER_DIM_CUBE ||
+		          glsl_get_sampler_dim(type) == GLSL_SAMPLER_DIM_3D;
 
 		LLVMValueRef coords = params[param_count++] = get_image_coords(ctx, instr);
 		params[param_count++] = get_sampler_desc(ctx, instr->variables[0], AC_DESC_IMAGE,
-- 
2.16.2



More information about the mesa-dev mailing list