[Mesa-dev] [PATCH] virgl: native fence fd support
Emil Velikov
emil.l.velikov at gmail.com
Tue Feb 20 18:28:52 UTC 2018
Hi Gustavo,
Slightly pedantic suggestion: one could consider splitting the
refactor from the remainder of the changes.
There's a small memory leak below since my virtgpu-foo is limited ;-)
On 16 February 2018 at 15:01, Gustavo Padovan <gustavo at padovan.org> wrote:
> +static int virgl_drm_get_version(int fd)
> +{
> + drmVersionPtr version;
> +
> + version = drmGetVersion(fd);
> + if (!version)
> + return -EFAULT;
> +
> + if (version->version_major != 0)
> + return -EINVAL;
> +
> + return version->version_minor;
version should be freed with drmFreeVersion.
HTH
Emil
More information about the mesa-dev
mailing list