[Mesa-dev] [PATCH 5/7] ac/radeonsi: pass bindless bool to load_sampler_desc()

[Timothy Arceri]

On 21/02/18 10:33, Marek Olšák wrote:
> On Tue, Feb 20, 2018 at 11:51 PM, Timothy Arceri <tarceri at itsqueeze.com> wrote:
>> On 21/02/18 09:46, Marek Olšák wrote:
>>>
>>> On Tue, Feb 20, 2018 at 11:42 PM, Marek Olšák <maraeo at gmail.com> wrote:
>>>>
>>>> For patches 1-5:
>>>>
>>>> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>>>
>>>
>>> Actually no. Only patches 1, 3, 5 are reviewed by me.
>>>
>>> Marek
>>
>>
>> Do you have an issue with patch 4?
> 
> No, I'm just not sure if it's correct. It calls
> st_nir_lookup_parameter_index, but bindless handless are just
> variables. I think it should just visit the whole expression leading
> to the bindless variable in a generic way and not treat it as a
> uniform.

I'm not sure I understand. We use uniform storage for bindless in tgsi 
also.

> 
> Marek
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>