[Mesa-dev] [PATCH 1/2] radv: remove one invalid case in radv_tex_dim()

[Józef Kucia]

On Wed, Feb 21, 2018 at 3:27 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> According to "Table 1. Image and image view parameter compatibility
> requirements", this is invalid.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_image.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
> index 5ac0f72589..ae407198ba 100644
> --- a/src/amd/vulkan/radv_image.c
> +++ b/src/amd/vulkan/radv_image.c
> @@ -337,10 +337,7 @@ static unsigned radv_tex_dim(VkImageType image_type, VkImageViewType view_type,
>                 else
>                         return nr_layers > 1 ? V_008F1C_SQ_RSRC_IMG_2D_ARRAY : V_008F1C_SQ_RSRC_IMG_2D;
>         case VK_IMAGE_TYPE_3D:
> -               if (view_type == VK_IMAGE_VIEW_TYPE_3D)
> -                       return V_008F1C_SQ_RSRC_IMG_3D;
> -               else
> -                       return V_008F1C_SQ_RSRC_IMG_2D_ARRAY;
> +               return V_008F1C_SQ_RSRC_IMG_3D;

VK_KHR_maintenance1 allows 2D image views to to be created from 3D images.