[Mesa-dev] [PATCH 1/6] i965/state: Ignore intel_obj->_Format for depth/stencil and ETC2

[Chad Versace]

On Tue 20 Feb 2018, Jason Ekstrand wrote:
> On Mon, Feb 19, 2018 at 10:01 AM, Chad Versace <[1]chadversary at chromium.org>
> wrote:
> 
>     On Wed 24 Jan 2018, Jason Ekstrand wrote:
>     > We're about to start letting the intel_obj->_Format be the "real"
>     > texture format.  For depth/stencil textures, this may be a combined
>     > depth stencil format.  For ETC2 on gen7 and earlier, this will be the
>     > actual ETC2 format.  This makes a bit more GL sense but means we have to
>     > be careful in state upload.
> 
>     What is the "real" format? It's not a rhetorical question. Throughout
>     Mesa, I never know what's real and what's not. By "real", do you mean
>     the untranslated user-specified glTextureView(internalformat) and
>     glTexImage2D(internalformat)?  Or do you mean simply "more real than
>     before" ;)
> 
> 
> By "real" format, I mean the one that the core mesa state tracking code thinks
> it is.  For texture views, that corresponds directly to an actual GL internal
> format.  For textures created through glTexImage2D (not TexStorage) with an
> internal format such as GL_RGB, it's something computed from the internal
> format and the format used for upload.

I understand now. Sounds good to me.

Reviewed-by: Chad Versace <chadversary at chromium.org>