[Mesa-dev] [PATCH] nvc0: fix writing query results into buffer

Karol Herbst kherbst at redhat.com
Thu Feb 22 13:05:48 UTC 2018


Tested-by: Karol Herbst <kherbst at redhat.com>

On Wed, Feb 21, 2018 at 6:17 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> We need to mark the range as valid, and validate the resource using a
> helper to ensure that the buffer status is marked properly.
>
> Fixes some CTS pipeline stats query tests.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c
> index 7568eeb94db..ef5f939319a 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c
> @@ -473,10 +473,10 @@ nvc0_hw_get_query_result_resource(struct nvc0_context *nvc0,
>     PUSH_DATAh(push, buf->address + offset);
>     PUSH_DATA (push, buf->address + offset);
>
> -   if (buf->mm) {
> -      nouveau_fence_ref(nvc0->screen->base.fence.current, &buf->fence);
> -      nouveau_fence_ref(nvc0->screen->base.fence.current, &buf->fence_wr);
> -   }
> +   util_range_add(&buf->valid_buffer_range, offset,
> +                  offset + (result_type >= PIPE_QUERY_TYPE_I64 ? 8 : 4));
> +
> +   nvc0_resource_validate(buf, NOUVEAU_BO_WR);
>  }
>
>  static const struct nvc0_query_funcs hw_query_funcs = {
> --
> 2.16.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list