[Mesa-dev] [PATCH] egl/dri2: fix segfault when display initialisation fails

[Emil Velikov]

On 22 February 2018 at 17:25, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> On Thursday, 2018-02-22 13:37:54 +0000, Frank Binns wrote:
>> dri2_display_destroy() is called when platform specific display
>> initialisation fails. However, this would typically lead to a
>> segfault due to the dri2_egl_display vbtl not having been set up.
>>
>> Fixes: 2db95482964 ("loader_dri3/glx/egl: Optionally use a blit
>> context for blitting operations")
>> Signed-off-by: Frank Binns <francisbinns at gmail.com>
>
> Error paths are basically never tested...
> You're entirely right, thanks for catching this!
>
> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
>
Yay error paths.

Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil