[Mesa-dev] [PATCH v2] gallium/tgsi: remove is_msaa_sampler array from tgsi_shader_info

Samuel Pitoiset samuel.pitoiset at gmail.com
Fri Feb 23 09:09:48 UTC 2018


Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 02/23/2018 03:56 AM, Timothy Arceri wrote:
> Seems to have not been used since 16be87c90429
> ---
>   src/gallium/auxiliary/tgsi/tgsi_scan.c | 6 ------
>   src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 -
>   2 files changed, 7 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c
> index 989c57ebee..c35eff25ba 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_scan.c
> +++ b/src/gallium/auxiliary/tgsi/tgsi_scan.c
> @@ -267,7 +267,6 @@ scan_src_operand(struct tgsi_shader_info *info,
>         const unsigned index = src->Register.Index;
>   
>         assert(fullinst->Instruction.Texture);
> -      assert(index < ARRAY_SIZE(info->is_msaa_sampler));
>         assert(index < PIPE_MAX_SAMPLERS);
>   
>         if (is_texture_inst(fullinst->Instruction.Opcode)) {
> @@ -286,11 +285,6 @@ scan_src_operand(struct tgsi_shader_info *info,
>                */
>               assert(info->sampler_targets[index] == target);
>            }
> -         /* MSAA samplers */
> -         if (target == TGSI_TEXTURE_2D_MSAA ||
> -             target == TGSI_TEXTURE_2D_ARRAY_MSAA) {
> -            info->is_msaa_sampler[src->Register.Index] = TRUE;
> -         }
>         }
>      }
>   
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.h b/src/gallium/auxiliary/tgsi/tgsi_scan.h
> index 0f872b0022..1887ff342d 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_scan.h
> +++ b/src/gallium/auxiliary/tgsi/tgsi_scan.h
> @@ -132,7 +132,6 @@ struct tgsi_shader_info
>      boolean writes_viewport_index;
>      boolean writes_layer;
>      boolean writes_memory; /**< contains stores or atomics to buffers or images */
> -   boolean is_msaa_sampler[PIPE_MAX_SAMPLERS];
>      boolean uses_doubles; /**< uses any of the double instructions */
>      boolean uses_derivatives;
>      boolean uses_bindless_samplers;
> 


More information about the mesa-dev mailing list