[Mesa-dev] [PATCH 2/2] ac: fix f2b and i2b for doubles

Timothy Arceri tarceri at itsqueeze.com
Mon Feb 26 05:14:26 UTC 2018


Without this llvm was asserting in debug builds.
---
 src/amd/common/ac_nir_to_llvm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index f37f19404e..1ff074e2ff 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@ -1437,8 +1437,9 @@ static LLVMValueRef emit_f2b(struct ac_llvm_context *ctx,
 			     LLVMValueRef src0)
 {
 	src0 = ac_to_float(ctx, src0);
+	LLVMValueRef zero = ac_get_zero_for_type(ctx, LLVMTypeOf(src0));
 	return LLVMBuildSExt(ctx->builder,
-			     LLVMBuildFCmp(ctx->builder, LLVMRealUNE, src0, ctx->f32_0, ""),
+			     LLVMBuildFCmp(ctx->builder, LLVMRealUNE, src0, zero, ""),
 			     ctx->i32, "");
 }
 
@@ -1457,8 +1458,9 @@ static LLVMValueRef emit_b2i(struct ac_llvm_context *ctx,
 static LLVMValueRef emit_i2b(struct ac_llvm_context *ctx,
 			     LLVMValueRef src0)
 {
+	LLVMValueRef zero = ac_get_zero_for_type(ctx, LLVMTypeOf(src0));
 	return LLVMBuildSExt(ctx->builder,
-			     LLVMBuildICmp(ctx->builder, LLVMIntNE, src0, ctx->i32_0, ""),
+			     LLVMBuildICmp(ctx->builder, LLVMIntNE, src0, zero, ""),
 			     ctx->i32, "");
 }
 
-- 
2.14.3



More information about the mesa-dev mailing list