[Mesa-dev] [PATCH] meson: fix building without GL

Dylan Baker dylan at pnwbakers.com
Mon Feb 26 17:31:41 UTC 2018


Quoting Emil Velikov (2018-02-26 09:11:35)
> On 26 February 2018 at 16:46, Dylan Baker <dylan at pnwbakers.com> wrote:
> > libgl will be undefined if with_glx == 'disabled', so move that check
> > inside the `if with_glx == 'disabled'` block immediately after that
> > check.
> >
> There's some of repetition, making this hard to read. Perhaps:
> 
> "libgl will be undefined glx is disabled, so move that just after the
> with_glx != 'disabled' check"
> 
> Either way
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> -Emil

Done, thanks Emil.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180226/68473ba8/attachment.sig>


More information about the mesa-dev mailing list