[Mesa-dev] [PATCH] disk cache: Link with -latomic if necessary

[Thierry Reding]

On Mon, Feb 26, 2018 at 11:14:05AM -0800, Matt Turner wrote:
> On Fri, Feb 23, 2018 at 5:18 AM, Thierry Reding
> <thierry.reding at gmail.com> wrote:
> > From: Thierry Reding <treding at nvidia.com>
> >
> > The disk cache implementation uses 64-bit atomic operations. For some
> > architectures, such as 32-bit ARM, GCC will not be able to translate
> > these operations into lock-free instructions and will instead rely on
> 
> Here, and in the comment in meson.build, I think you mean "atomic"
> rather than "lock-free" instructions? It's at least confusing, since
> on x86 atomic instructions have a "lock" prefix.

This uses the terminology used by the GCC documentation, see:

	https://gcc.gnu.org/wiki/Atomic/GCCMM

I think the GCC terms merely mean that you don't need any explicit
locking for these operations to be atomic.

How about this instead:

	"... operations into atomic, lock-free instructions..."

?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180227/ed7723ea/attachment.sig>