[Mesa-dev] [PATCH 01/22] i965: Silence unused parameter warnings

Samuel Iglesias Gonsálvez siglesias at igalia.com
Tue Feb 27 11:00:28 UTC 2018


Patches 1-10 are,

Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

Sam


On 24/02/18 00:55, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> Reduces my build from 7119 warnings to 7005 warnings by silencing 114
> instances of
>
> In file included from ../../SOURCE/master/src/mesa/drivers/dri/i965/brw_context.h:46:0,
>                  from ../../SOURCE/master/src/mesa/drivers/dri/i965/intel_pixel_read.c:38:
> ../../SOURCE/master/src/mesa/drivers/dri/i965/brw_bufmgr.h: In function ‘brw_bo_unmap’:
> ../../SOURCE/master/src/mesa/drivers/dri/i965/brw_bufmgr.h:258:47: warning: unused parameter ‘bo’ [-Wunused-parameter]
>  static inline int brw_bo_unmap(struct brw_bo *bo) { return 0; }
>                                                ^~
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_bufmgr.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.h b/src/mesa/drivers/dri/i965/brw_bufmgr.h
> index 005ff19..851f466 100644
> --- a/src/mesa/drivers/dri/i965/brw_bufmgr.h
> +++ b/src/mesa/drivers/dri/i965/brw_bufmgr.h
> @@ -252,7 +252,7 @@ MUST_CHECK void *brw_bo_map(struct brw_context *brw, struct brw_bo *bo, unsigned
>   * Reduces the refcount on the userspace mapping of the buffer
>   * object.
>   */
> -static inline int brw_bo_unmap(struct brw_bo *bo) { return 0; }
> +static inline int brw_bo_unmap(UNUSED struct brw_bo *bo) { return 0; }
>  
>  /** Write data into an object. */
>  int brw_bo_subdata(struct brw_bo *bo, uint64_t offset,

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180227/258de1d0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180227/258de1d0/attachment.sig>


More information about the mesa-dev mailing list