[Mesa-dev] [PATCH] ac/radv: move load base vertex abi setup to vertex shader.

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Tue Feb 27 23:56:32 UTC 2018


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Wed, Feb 28, 2018 at 12:55 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> This was segfaulting:
> dEQP-VK.memory.pipeline_barrier.host_write_index_buffer.1024
>
> Fixes: 8de6f797070 (ac/radeonsi: add load_base_vertex() to the abi)
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/common/ac_nir_to_llvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 44d96d27d7..8b662f884f 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -6920,7 +6920,6 @@ LLVMModuleRef ac_translate_nir_to_llvm(LLVMTargetMachineRef tm,
>                         ctx.gs_max_out_vertices = shaders[i]->info.gs.vertices_out;
>                         ctx.abi.load_inputs = load_gs_input;
>                         ctx.abi.emit_primitive = visit_end_primitive;
> -                       ctx.abi.load_base_vertex = radv_load_base_vertex;
>                 } else if (shaders[i]->info.stage == MESA_SHADER_TESS_CTRL) {
>                         ctx.tcs_outputs_read = shaders[i]->info.outputs_read;
>                         ctx.tcs_patch_outputs_read = shaders[i]->info.patch_outputs_read;
> @@ -6944,6 +6943,7 @@ LLVMModuleRef ac_translate_nir_to_llvm(LLVMTargetMachineRef tm,
>                                                 MAX2(1, ctx.shader_info->vs.vgpr_comp_cnt);
>                                 }
>                         }
> +                       ctx.abi.load_base_vertex = radv_load_base_vertex;
>                 } else if (shaders[i]->info.stage == MESA_SHADER_FRAGMENT) {
>                         shader_info->fs.can_discard = shaders[i]->info.fs.uses_discard;
>                         ctx.abi.lookup_interp_param = lookup_interp_param;
> --
> 2.14.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list