[Mesa-dev] [PATCH 04/12] vbo: Implement vbo_loopback_vertex_list in terms of the VAO.

[Mathias Fröhlich]

Hi Brian,

On Wednesday, 28 February 2018 00:55:33 CET Brian Paul wrote:
> Minor nit-picks below.
> > @@ -94,17 +94,15 @@ struct loopback_attr {
> >    */
> >   static void
> >   loopback_prim(struct gl_context *ctx,
> > -              const GLfloat *buffer,
> > +              const GLubyte *buffer,
> >                 const struct _mesa_prim *prim,
> >                 GLuint wrap_count,
> > -              GLuint vertex_size,
> > +              GLuint stride,
> >                 const struct loopback_attr *la, GLuint nr)
> >   {
> > -   GLint start = prim->start;
> > -   GLint end = start + prim->count;
> > -   const GLfloat *data;
> > -   GLint j;
> > -   GLuint k;
> > +   GLuint start = prim->start;
> > +   GLuint end = start + prim->count;
> 
> const on those two?

start may be modified afterwards by that wrap_count offset.
So I can't constify start. But end is now constified.

Thanks for the review!!

best

Mathias