[Mesa-dev] [RFC PATCH] get_reviewer.pl: Delete

[Rob Clark]

On Wed, Feb 28, 2018 at 4:09 PM, Eric Anholt <eric at anholt.net> wrote:
> Matt Turner <mattst88 at gmail.com> writes:
>
>> I find this script *really* annoying. Getting Cc'd on a random sample of
>> a series is doing it wrong. Cc lists of 14 people is doing it wrong.
>>
>> Let's start the negotiation with "delete this script" and see if anyone
>> can come up with a way of making this not so stupid.
>
> Patch submission done well IMO would be something like github PRs, with
> a bot that auto-tags people based on a MAINTAINERS-style opt-in for
> reviewing certain paths within the tree.
>
> I don't think get_reviewers.pl improves the git-send-email situation
> compared to maintainers needing to manage email filters.  It's not
> consistent, so you need to indoctrinate new submitters (more barriers to
> entry!) and maintainers need to maintain their mail filters anyway.

Hmm, you have mail filters that parse paths in git patches?

Possibly tweaking the script to *only* consult MAINTAINERS file, as
Dylan suggested, would be a reasonable solution.

As far as indoctrinating new submitters, well it is the same as the
kernel process so it seemed natural to me, but I guess it depends on
what other projects a submitter contributes to..

BR,
-R


> Reviewed-by: Eric Anholt <eric at anholt.net>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>