[Mesa-dev] [PATCH] nir/serialize: handle var->name being NULL

Timothy Arceri tarceri at itsqueeze.com
Wed Feb 28 23:14:22 UTC 2018


Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 01/03/18 04:13, Alejandro PiƱeiro wrote:
> var->name could be true under ARB_gl_spirv for example. And in any
> case, the code is already handing var name being NULL when reading a
> variable, so it is consistent to do it writing a variable too.
> ---
>   src/compiler/nir/nir_serialize.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/compiler/nir/nir_serialize.c b/src/compiler/nir/nir_serialize.c
> index 9fe46a675f6..00df49c2ef3 100644
> --- a/src/compiler/nir/nir_serialize.c
> +++ b/src/compiler/nir/nir_serialize.c
> @@ -137,7 +137,8 @@ write_variable(write_ctx *ctx, const nir_variable *var)
>      write_add_object(ctx, var);
>      encode_type_to_blob(ctx->blob, var->type);
>      blob_write_uint32(ctx->blob, !!(var->name));
> -   blob_write_string(ctx->blob, var->name);
> +   if (var->name)
> +      blob_write_string(ctx->blob, var->name);
>      blob_write_bytes(ctx->blob, (uint8_t *) &var->data, sizeof(var->data));
>      blob_write_uint32(ctx->blob, var->num_state_slots);
>      blob_write_bytes(ctx->blob, (uint8_t *) var->state_slots,
> 


More information about the mesa-dev mailing list