[Mesa-dev] [PATCH v2] i965/sbe: fix number of inputs for active components

Kenneth Graunke kenneth at whitecape.org
Wed Feb 28 23:37:35 UTC 2018

On Monday, February 26, 2018 11:02:08 PM PST Iago Toral Quiroga wrote:
> In 16631ca30ea6 we fixed gen9 active components to account for padded
> inputs in the URB, which we can have with SSO programs. To do that,
> instead of going through the bitfield of inputs (which doesn't include
> padding information), we compute the number of inputs from the size
> of the URB entry.
> Unfortunately, there are some special inputs that are not stored in
> the URB and that we also need to account for. These special inputs
> are identified and handled during calculate_attr_overrides(), so this
> patch modifies this function to return a value with the total number
> of inputs, including the ones that are not stored in the URB, so we
> can use that number to program the correct number of active components.
> This fixes a regression in a WebGL program that uses Point Sprite
> functionality (specifically, VARYING_SLOT_PNTC).
> v2:
>  - Add 'Fixes' tag (Mark Janes)
>  - make no_vue_inputs int instead of uint32_t, and add const qualifier
>    to num_inputs variable (Ian)
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105224
> Fixes: 16631ca30ea6 (i965/sbe: fix active components for SSO programs with over 16 inputs)
> ---
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 31 ++++++++++++++++++++-------
>  1 file changed, 23 insertions(+), 8 deletions(-)

:(  Thanks for fixing this, Iago.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180228/8bc4f767/attachment.sig>

More information about the mesa-dev mailing list