[Mesa-dev] [PATCH 2/4] glsl/standalone: set MaxUniformBufferBindings

[Ian Romanick]

On 01/04/2018 08:18 AM, Alejandro Piñeiro wrote:
> Used to handle how many ubo you can define on the context. Minimimum
> defined as 36 on ARB_uniform_buffer_object spec, up to 84 on OpenGL
> 4.6 (12 per stage at each moment).
> ---
>  src/compiler/glsl/standalone.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/compiler/glsl/standalone.cpp b/src/compiler/glsl/standalone.cpp
> index 85e94a1095b..3474ada7519 100644
> --- a/src/compiler/glsl/standalone.cpp
> +++ b/src/compiler/glsl/standalone.cpp
> @@ -229,6 +229,7 @@ initialize_context(struct gl_context *ctx, gl_api api)
>        ctx->Const.MaxLights = 8;
>        ctx->Const.MaxTextureCoordUnits = 8;
>        ctx->Const.MaxTextureUnits = 2;
> +      ctx->Const.MaxUniformBufferBindings = 84;
>  
>        ctx->Const.Program[MESA_SHADER_VERTEX].MaxAttribs = 16;
>        ctx->Const.Program[MESA_SHADER_VERTEX].MaxTextureImageUnits = 16;
> @@ -245,6 +246,7 @@ initialize_context(struct gl_context *ctx, gl_api api)
>        ctx->Const.Program[MESA_SHADER_FRAGMENT].MaxOutputComponents = 0; /* not used */
>  
>        ctx->Const.MaxVarying = ctx->Const.Program[MESA_SHADER_VERTEX].MaxOutputComponents / 4;
> +
>        break;
>     case 150:
>     case 330:

If you drop this spurious whitespace change hunk, the series is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> @@ -262,6 +264,7 @@ initialize_context(struct gl_context *ctx, gl_api api)
>        ctx->Const.MaxLights = 8;
>        ctx->Const.MaxTextureCoordUnits = 8;
>        ctx->Const.MaxTextureUnits = 2;
> +      ctx->Const.MaxUniformBufferBindings = 84;
>  
>        ctx->Const.Program[MESA_SHADER_VERTEX].MaxAttribs = 16;
>        ctx->Const.Program[MESA_SHADER_VERTEX].MaxTextureImageUnits = 16;
> @@ -303,6 +306,7 @@ initialize_context(struct gl_context *ctx, gl_api api)
>        ctx->Const.MaxLights = 0;
>        ctx->Const.MaxTextureCoordUnits = 0;
>        ctx->Const.MaxTextureUnits = 0;
> +      ctx->Const.MaxUniformBufferBindings = 84;
>  
>        ctx->Const.Program[MESA_SHADER_VERTEX].MaxAttribs = 16;
>        ctx->Const.Program[MESA_SHADER_VERTEX].MaxTextureImageUnits = 16;
>