[Mesa-dev] [PATCH v2 3/3] anv/blorp: do not clear with hiz if multiview is in use

Iago Toral Quiroga itoral at igalia.com
Fri Jan 5 16:38:31 UTC 2018


When multiview is used we need to clear all the layers selected
by the view mask. Currently blorp_gen8_hiz_clear_attachments
doesn't support this.
---

This is just something I noticed at the last moment so this is just
a quick fix to avoid doing something wrong, ideally I guess we would
make blorp_gen8_hiz_clear_attachments support start_layer so we can
use it also with multiview. I can try to work on that too unless there
is a good reason why this function doesn't support that.

 src/intel/vulkan/anv_blorp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
index 0dac20ea80..880654a6f2 100644
--- a/src/intel/vulkan/anv_blorp.c
+++ b/src/intel/vulkan/anv_blorp.c
@@ -1353,6 +1353,8 @@ anv_cmd_buffer_clear_subpass(struct anv_cmd_buffer *cmd_buffer)
                 * not support this feature at all.
                 */
                clear_with_hiz = false;
+            } else if (cmd_state->subpass->view_mask != 0x01) {
+               clear_with_hiz = false;
             }
          }
 
-- 
2.11.0



More information about the mesa-dev mailing list