[Mesa-dev] [PATCH 11/14] meson: fix missing dependencies

Dylan Baker dylan at pnwbakers.com
Fri Jan 5 22:36:30 UTC 2018


Quoting Greg V (2017-12-31 08:55:25)
> ---
>  src/gallium/drivers/radeonsi/meson.build | 2 +-
>  src/mesa/meson.build                     | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/radeonsi/meson.build b/src/gallium/drivers/radeonsi/meson.build
> index 58132bf072..8a7045de0d 100644
> --- a/src/gallium/drivers/radeonsi/meson.build
> +++ b/src/gallium/drivers/radeonsi/meson.build
> @@ -77,7 +77,7 @@ libradeonsi = static_library(
>    ],
>    c_args : [c_vis_args],
>    cpp_args : [cpp_vis_args],
> -  dependencies : dep_llvm,
> +  dependencies : [dep_llvm, dep_libdrm],
>  )

I believe this could be correct, but I don't see this in autotools or scons,
what is the error you're seeing?

>  
>  driver_radeonsi = declare_dependency(
> diff --git a/src/mesa/meson.build b/src/mesa/meson.build
> index ab6bc27312..74b8d97231 100644
> --- a/src/mesa/meson.build
> +++ b/src/mesa/meson.build
> @@ -721,6 +721,7 @@ libmesa_gallium = static_library(
>    cpp_args : [cpp_vis_args, cpp_msvc_compat_args],
>    include_directories : [inc_common, include_directories('main')],
>    link_with : [libglsl, libmesa_sse41],
> +  dependencies : [dep_vdpau],
>    build_by_default : false,
>  )

This is wrong, there is no way that core mesa needs to link against vdpau, what
error are you fixing?

>  
> -- 
> 2.15.1
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180105/c69ef75f/attachment.sig>


More information about the mesa-dev mailing list