[Mesa-dev] [PATCH 01/21] r600: emit 0 gds_op for tf write.

Dave Airlie airlied at gmail.com
Wed Jan 10 06:48:40 UTC 2018


From: Dave Airlie <airlied at redhat.com>

This field is ignored for tf writes so should be 0.

Signed-off-by: Dave Airlie <airlied at redhat.com>
---
 src/gallium/drivers/r600/eg_asm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/r600/eg_asm.c b/src/gallium/drivers/r600/eg_asm.c
index 8f9d1b85f2..f8651bdff5 100644
--- a/src/gallium/drivers/r600/eg_asm.c
+++ b/src/gallium/drivers/r600/eg_asm.c
@@ -225,9 +225,10 @@ int eg_bytecode_gds_build(struct r600_bytecode *bc, struct r600_bytecode_gds *gd
 {
 	unsigned gds_op = (r600_isa_fetch_opcode(bc->isa->hw_class, gds->op) >> 8) & 0x3f;
 	unsigned opcode;
-	if (gds->op == FETCH_OP_TF_WRITE)
+	if (gds->op == FETCH_OP_TF_WRITE) {
 		opcode = 5;
-	else
+		gds_op = 0;
+	} else
 		opcode = 4;
 	bc->bytecode[id++] = S_SQ_MEM_GDS_WORD0_MEM_INST(2) |
 		S_SQ_MEM_GDS_WORD0_MEM_OP(opcode) |
-- 
2.14.3



More information about the mesa-dev mailing list