[Mesa-dev] [PATCH] ac/nir: Sanitize location_frac for local variables.

[Timothy Arceri]

Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 11/01/18 03:24, Bas Nieuwenhuizen wrote:
> If they were promoted from inputs/outputs, they could have a
> non-zero value left over, which messed with our store handling.
> 
> Fixes: 06f05040eb "radv: Link shaders."
> ---
>   src/amd/common/ac_nir_to_llvm.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 932d648082..3fdb7f7b8b 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -5567,6 +5567,7 @@ setup_locals(struct ac_nir_context *ctx,
>   	nir_foreach_variable(variable, &func->impl->locals) {
>   		unsigned attrib_count = glsl_count_attribute_slots(variable->type, false);
>   		variable->data.driver_location = ctx->num_locals * 4;
> +		variable->data.location_frac = 0;
>   		ctx->num_locals += attrib_count;
>   	}
>   	ctx->locals = malloc(4 * ctx->num_locals * sizeof(LLVMValueRef));
>