[Mesa-dev] [PATCH 05/21] r600/sb: start adding GDS support

[Roland Scheidegger]

Am 10.01.2018 um 07:48 schrieb Dave Airlie:
> From: Dave Airlie <airlied at redhat.com>
> 
> This adds support for GDS ops to sb backend.
> 
> This seems to work for atomics and tess factor writes.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>

> diff --git a/src/gallium/drivers/r600/sb/sb_bc_finalize.cpp b/src/gallium/drivers/r600/sb/sb_bc_finalize.cpp
> index 7f1dd0a7a0..c20640e476 100644
> --- a/src/gallium/drivers/r600/sb/sb_bc_finalize.cpp
> +++ b/src/gallium/drivers/r600/sb/sb_bc_finalize.cpp
> @@ -557,6 +557,8 @@ void bc_finalizer::finalize_fetch(fetch_node* f) {
>  
>  	if (flags & FF_VTX) {
>  		src_count = 1;
> +	} else if (flags & FF_GDS) {
> +		src_count = 2;
the tf write ones don't really have 2 sources. But I suppose this isn't
a problem here...

In any case, the rest of the series looks great to me (with the
exception of the last 2), but I'm not really qualified to review (just
learning a bit about r600 code for fun...) so
5-19 are Acked-By: Roland Scheidegger <sroland at vmware.com>