[Mesa-dev] [PATCH 0/6] i965: Misc sRGB and CCS fixes

Iago Toral itoral at igalia.com
Thu Jan 11 10:28:00 UTC 2018


I sent minor comments to for patch 2, with or without those patches 1-4 
are:

Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

I don't think I understand patch 5 well enough and because of that I
still don't see how patch 6 achieves its purpose.

Iago

On Wed, 2018-01-10 at 11:22 -0800, Jason Ekstrand wrote:
> This series contains the fixes required to fully re-enable CCS for
> sRGB
> render buffers.  A bunch of these patches have been sent out
> individually
> or in smaller series but they sort-of all go together.
> 
> Jason Ekstrand (6):
>   i965: Call brw_cache_flush_for_render in
> predraw_resolve_framebuffer
>   i965: Track format and aux usage in the render cache
>   Re-enable regular fast-clears (CCS_D) on gen9+
>   i965/miptree: Refactor CCS_E and CCS_D cases in render_aux_usage
>   i965/draw: Do resolves properly for textures used by TXF
>   i965: Enable CCS_E sampling of sRGB textures as UNORM
> 
>  src/mesa/drivers/dri/i965/brw_context.h       |  2 +-
>  src/mesa/drivers/dri/i965/brw_draw.c          | 53
> +++++++++++++++++++++-
>  src/mesa/drivers/dri/i965/brw_meta_util.c     | 10 -----
>  src/mesa/drivers/dri/i965/genX_blorp_exec.c   | 14 ++++--
>  src/mesa/drivers/dri/i965/intel_fbo.c         | 65
> +++++++++++++++++++++------
>  src/mesa/drivers/dri/i965/intel_fbo.h         |  8 +++-
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 62 +++++++++++----
> ----------
>  7 files changed, 147 insertions(+), 67 deletions(-)
> 


More information about the mesa-dev mailing list