[Mesa-dev] [PATCH] mesa: require at least 14 UBOs for GL 4.3

[Brian Paul]

On 01/10/2018 06:14 PM, sroland at vmware.com wrote:
> From: Roland Scheidegger <sroland at vmware.com>
> 
> ARB_ubo requires 12 UBOs (per stage) at least, but this limit has been
> raised by GL 4.3 to 14, so don't advertize GL 4.3 without it (only checking
> the vertex stage since all drivers probably have the same limit anyway for
> other stages). (piglit has minmax tests for that kind of thing, but they go
> only up to 3.3, so this won't really be noticed.)
> I think this currently should not affect any driver - r600 until very
> recently only supported 12 but now advertizes 14 too.
> ---
>   src/mesa/main/version.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
> index 90c5c5f..68079f4 100644
> --- a/src/mesa/main/version.c
> +++ b/src/mesa/main/version.c
> @@ -352,6 +352,7 @@ compute_version(const struct gl_extensions *extensions,
>                            extensions->ARB_transform_feedback_instanced);
>      const bool ver_4_3 = (ver_4_2 &&
>                            consts->GLSLVersion >= 430 &&
> +                         consts->Program[MESA_SHADER_VERTEX].MaxUniformBlocks >= 14 &&
>                            extensions->ARB_ES3_compatibility &&
>                            extensions->ARB_arrays_of_arrays &&
>                            extensions->ARB_compute_shader &&
> 

Reviewed-by: Brian Paul <brianp at vmware.com>