[Mesa-dev] [PATCH 2/2] radv: inline push constants where possible.

Dave Airlie airlied at gmail.com
Fri Jan 12 02:35:20 UTC 2018


On 11 January 2018 at 20:15, Alex Smith <asmith at feralinteractive.com> wrote:
> Hi Dave,
>
> This seems to cause some breakage when both push constants and dynamic
> descriptors are used.
>
> I've commented 2 fixes inline below needed to avoid a crash, but with those
> F1 2017 will still hang pretty quick before the main menu, not sure why so
> far. Mad Max is OK but that doesn't use dynamic descriptors, so I presume
> the problem is related to that.

I found the issue, will resend patch.

You seem like you split the push const space between VS and FS at 63,
and I messed up with handling a push const base > 32.

Thanks for testing,
Dave.


More information about the mesa-dev mailing list