[Mesa-dev] [PATCH] ac: fix buffer overflow bug in 64bit SSBO loads

Timothy Arceri tarceri at itsqueeze.com
Tue Jan 16 06:45:30 UTC 2018


Fixes: 441ee1e65b04 "radv/ac: Implement Float64 SSBO loads"
---
 src/amd/common/ac_nir_to_llvm.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 6467ed66ae..4a80748e4e 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@ -2585,8 +2585,11 @@ static LLVMValueRef visit_load_buffer(struct ac_nir_context *ctx,
 			ctx->ac.i1false,
 		};
 
-		results[i] = ac_build_intrinsic(&ctx->ac, load_name, data_type, params, 5, 0);
+		int idx = i;
+		if (instr->dest.ssa.bit_size == 64)
+			idx = i > 1 ? 1 : 0;
 
+		results[idx] = ac_build_intrinsic(&ctx->ac, load_name, data_type, params, 5, 0);
 	}
 
 	assume(results[0]);
-- 
2.14.3



More information about the mesa-dev mailing list