[Mesa-dev] [PATCH] st/dri: Default ALLOW_RGB10_CONFIGS to false on gallium as well.

Mario Kleiner mario.kleiner.de at gmail.com
Wed Jan 17 02:21:09 UTC 2018


On 01/16/2018 11:47 PM, Marek Olšák wrote:
> Why?

Because the bug reports i've seen so far seem to be not caused by 
something specific to the i965 implementation, but by some other client 
application or compositor being incompatible. Therefore i'd expect the 
same problems in clients/compositors to happen with gallium drivers.

E.g., the gnome-shell bugs happen on all 10 bit drivers. So it would 
make sense for rgb10 to be off by default consistently on all drivers, 
but with the ability to switch it on via drirc.

-mario

> 
> Marek
> 
> On Tue, Jan 16, 2018 at 5:39 AM, Mario Kleiner
> <mario.kleiner.de at gmail.com> wrote:
>> For consistency with the i965 default of "off".
>>
>> Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com>
>> ---
>>   src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/auxiliary/pipe-loader/driinfo_gallium.h b/src/gallium/auxiliary/pipe-loader/driinfo_gallium.h
>> index 505aae4..446bc06 100644
>> --- a/src/gallium/auxiliary/pipe-loader/driinfo_gallium.h
>> +++ b/src/gallium/auxiliary/pipe-loader/driinfo_gallium.h
>> @@ -32,5 +32,5 @@ DRI_CONF_SECTION_END
>>   DRI_CONF_SECTION_MISCELLANEOUS
>>      DRI_CONF_ALWAYS_HAVE_DEPTH_BUFFER("false")
>>      DRI_CONF_GLSL_ZERO_INIT("false")
>> -   DRI_CONF_ALLOW_RGB10_CONFIGS("true")
>> +   DRI_CONF_ALLOW_RGB10_CONFIGS("false")
>>   DRI_CONF_SECTION_END
>> --
>> 2.7.4
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list