[Mesa-dev] [PATCH v4] anv: return VK_ERROR_OUT_OF_DEVICE_MEMORY when surface size is out of HW limits

Samuel Iglesias Gonsálvez siglesias at igalia.com
Wed Jan 17 07:35:35 UTC 2018


Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
---
 src/intel/vulkan/anv_image.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 4d13e05e11f..72e408764d8 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -335,10 +335,8 @@ make_surface(const struct anv_device *dev,
       .usage = usage,
       .tiling_flags = tiling_flags);
 
-   /* isl_surf_init() will fail only if provided invalid input. Invalid input
-    * is illegal in Vulkan.
-    */
-   assert(ok);
+   if (!ok)
+      return VK_ERROR_OUT_OF_DEVICE_MEMORY;
 
    image->planes[plane].aux_usage = ISL_AUX_USAGE_NONE;
 
-- 
2.14.1



More information about the mesa-dev mailing list