[Mesa-dev] [PATCH 2/2] ac: set count correctly when storing doubles to ssbo

Nicolai Hähnle nhaehnle at gmail.com
Wed Jan 17 11:15:53 UTC 2018


On 17.01.2018 10:54, Timothy Arceri wrote:
> On 17/01/18 20:47, Timothy Arceri wrote:
>> Reseting to 4 would have only worked for dvec4, subtracting 4
>> from the original count will instead give us 6 when working with a
> 
> Sorry that should be: "give us 2 when working with a dvec3"

With that, both patches:

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>


>> dvec3.
>> ---
>>   src/amd/common/ac_nir_to_llvm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/amd/common/ac_nir_to_llvm.c 
>> b/src/amd/common/ac_nir_to_llvm.c
>> index c24e563695..bb4f90b3a0 100644
>> --- a/src/amd/common/ac_nir_to_llvm.c
>> +++ b/src/amd/common/ac_nir_to_llvm.c
>> @@ -2452,7 +2452,7 @@ static void visit_store_ssbo(struct 
>> ac_nir_context *ctx,
>>           if (count > 4) {
>>               writemask |= ((1u << (count - 4)) - 1u) << (start + 4);
>> -            count = 4;
>> +            count -= 4;
>>               elem_size_mul = 1;
>>           }
>>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.


More information about the mesa-dev mailing list